feat(desktop): move firefox config to homes and use home-manager modules

modules/home/desktop/browser/firefox/default.nix

@@ -1,52 +0,0 @@
-{
-  osConfig,
-  lib,
-  inputs,
-  system,
-  ...
-}:
-let
-  inherit (builtins) map listToAttrs;
-  inherit (lib) mkIf;
-  inherit (lib.lists) findFirstIndex;
-  inherit (inputs.nur.legacyPackages.${system}.repos.rycee) firefox-addons;
-  cfg = osConfig.desktop.browser.firefox;
-  profileCfg = id: {
-    inherit id;
-    #TODO: move this into an option?
-    settings = {
-      "extensions.autoDisableScopes" = 0; # Auto enable extensions
-    };
-    extensions = {
-      force = true;
-      packages = with firefox-addons; [
-        darkreader
-        gesturefy
-        sponsorblock
-        ublock-origin
-      ];
-    };
-  };
-  profiles = listToAttrs (
-    map (name: {
-      inherit name;
-      # If there are duplicate profile names, findFirstIndex will cause issues.
-      # We sanitize the input in nixosModules.desktop to avoid this.
-      value = profileCfg (findFirstIndex (x: x == name) null cfg.syncedProfiles);
-    }) cfg.syncedProfiles
-  );
-in
-{
-  config = mkIf cfg.enable {
-    home.persistence."/persist/home/rafiq".directories = [ ".mozilla/firefox" ];
-    home.sessionVariables.BROWSER = "firefox";
-    programs.firefox = {
-      enable = true;
-      inherit profiles;
-    };
-    stylix.targets.firefox = {
-      profileNames = cfg.syncedProfiles;
-      colorTheme.enable = true;
-    };
-  };
-}

modules/home/system/default.nix

@@ -1,12 +1,27 @@
-{ config, ... }:
+{ config, lib, ... }:
+let
+  inherit (lib) mkOption;
+  inherit (lib.types) listOf str;
+in
 {
-  home.persistence."/persist/home/${config.snowfallorg.user.name}" = {
-    directories = [
+  options = {
+    persistDirs = mkOption {
+      type = listOf str;
+      default = [ ];
+    };
+  };
+
+  config = {
+    home.persistence."/persist/home/${config.snowfallorg.user.name}" = {
+      directories = config.persistDirs;
+      allowOther = true;
+    };
+
+    persistDirs = [
       ".ssh"
       ".config/sops/age"
     ];
-    allowOther = true;
-  };
 
-  home.stateVersion = "24.11";
+    home.stateVersion = "24.11";
+  };
 }

modules/nixos/desktop/browser/default.nix

@@ -1,25 +0,0 @@
-{ lib, config, ... }:
-let
-  inherit (lib) mkEnableOption mkOption;
-  inherit (lib.types) listOf str;
-  inherit (lib.lists) allUnique;
-  cfg = config.desktop.browser;
-in
-{
-  options.desktop.browser = {
-    firefox = {
-      enable = mkEnableOption "";
-      syncedProfiles = mkOption {
-        type = listOf str;
-        default = [ ];
-      };
-    };
-  };
-
-  config.assertions = [
-    {
-      assertion = allUnique cfg.firefox.syncedProfiles;
-      message = "desktop.browser.firefox.syncedProfiles has duplicate elements.";
-    }
-  ];
-}

modules/nixos/desktop/browser/firefox/default.nix

@@ -0,0 +1,20 @@
+{ lib, config, ... }:
+let
+  inherit (lib)
+    mkEnableOption
+    mkIf
+    singleton
+    ;
+  cfg = config.desktop.browser.firefox;
+in
+{
+  options.desktop.browser.firefox.enable = mkEnableOption "";
+
+  config = mkIf cfg.enable {
+    home-manager.sharedModules = singleton {
+      persistDirs = singleton ".mozilla/firefox";
+      programs.firefox.enable = true;
+      stylix.targets.firefox.colorTheme.enable = true;
+    };
+  };
+}